Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-87691: clarify use of anchor in pathlib docs #100782

Merged
merged 7 commits into from
Jan 6, 2023

Commits on Jan 5, 2023

  1. pythongh-87691: clarify use of anchor and segment in pathlib docs

    This is feedback from python#100737 (comment)
    
    This matches the wording from the `os.path.join` docs better:
    https://docs.python.org/3/library/os.path.html#os.path.join
    
    In particular, the previous use of "anchor" was incorrect given the
    pathlib definition of "anchor".
    
    While matching wording, I noticed that the constructor section uses the
    word "segment". This word does not appear elsewhere in the docs or code;
    we already have "part" and "component" to refer to the same concept in the
    pathlib context.
    hauntsaninja committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    e5e1b94 View commit details
    Browse the repository at this point in the history
  2. fix rst

    hauntsaninja committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    ee8fc17 View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2023

  1. use "drive", "ignored"

    hauntsaninja committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    453cd76 View commit details
    Browse the repository at this point in the history
  2. use segment

    hauntsaninja committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    9be6410 View commit details
    Browse the repository at this point in the history
  3. revert segment

    hauntsaninja committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    9110498 View commit details
    Browse the repository at this point in the history
  4. Apply suggestions from code review

    Co-authored-by: Barney Gale <barney.gale@gmail.com>
    hauntsaninja and barneygale authored Jan 6, 2023
    Configuration menu
    Copy the full SHA
    ee484ba View commit details
    Browse the repository at this point in the history
  5. Update Doc/library/pathlib.rst

    Co-authored-by: Barney Gale <barney.gale@gmail.com>
    hauntsaninja and barneygale authored Jan 6, 2023
    Configuration menu
    Copy the full SHA
    05fe8dd View commit details
    Browse the repository at this point in the history