Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-99908 Update class documentation to use a modernized example #100433

Closed
wants to merge 3 commits into from

Conversation

JosephSBoyle
Copy link
Contributor

@JosephSBoyle JosephSBoyle commented Dec 22, 2022

Small update to the docs to improve on an outmoded example from 15 years ago.
The aim of this change is to give readers of the docs a more idiomatic example.

@cpython-cla-bot
Copy link

cpython-cla-bot bot commented Dec 22, 2022

The following commit authors need to sign the Contributor License Agreement:

Click the button to sign:
CLA not signed

@sobolevn
Copy link
Member

Hi, @JosephSBoyle! Could you please sign a CLA? We cannot accept your PR without it :(

@JosephSBoyle
Copy link
Contributor Author

JosephSBoyle commented Dec 22, 2022

Hi @sobolevn. I have accepted the CLA. Can you re-run the check please? (I had to change my email address in the commit to my GH one).

@sobolevn
Copy link
Member

sobolevn commented Dec 23, 2022

@JosephSBoyle are you sure that your git email is the same as your CLA email: joe.boyle@blackcowtech.uk?
Looks like CLA status is not updated :(
Usually it happens in <1 hour.

@JosephSBoyle
Copy link
Contributor Author

Hi @sobolevn, thanks for the reminder- I had to rebase and edit my email in the commit log to have the same email as my CLA. Should be fine now:)

@AlexWaygood
Copy link
Member

Hi @sobolevn, thanks for the reminder- I had to rebase and edit my email in the commit log to have the same email as my CLA. Should be fine now:)

Looks like the CLA bot is still being grumpy — it might be easier to just close the PR and recreate it :)

@JosephSBoyle JosephSBoyle marked this pull request as draft December 24, 2022 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants