Argument Clinic included return converters hard code use of _return_value

[brettcannon]

BPO	20461
Nosy	@larryhastings

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/larryhastings'
closed_at = None
created_at = <Date 2014-01-31.17:28:47.030>
labels = ['build', 'expert-argument-clinic']
title = 'Argument Clinic included return converters hard code use of ``_return_value``'
updated_at = <Date 2020-03-18.18:40:11.018>
user = 'https://github.com/brettcannon'

bugs.python.org fields:

activity = <Date 2020-03-18.18:40:11.018>
actor = 'brett.cannon'
assignee = 'larry'
closed = False
closed_date = None
closer = None
components = ['Build', 'Argument Clinic']
creation = <Date 2014-01-31.17:28:47.030>
creator = 'brett.cannon'
dependencies = []
files = []
hgrepos = []
issue_num = 20461
keywords = []
message_count = 1.0
messages = ['209808']
nosy_count = 1.0
nosy_names = ['larry']
pr_nums = []
priority = 'normal'
resolution = None
stage = 'test needed'
status = 'open'
superseder = None
type = None
url = 'https://bugs.python.org/issue20461'
versions = ['Python 3.4']

Linked PRs

• gh-64660: Don't hardcode Argument Clinic return converter result variable name #104200

[brettcannon]

E.g. NoneType_return_converter assumes _return_value is used in render() although CReturnConverter.declare() stores it in data.return_value and it's a parameter to render().

[erlend-aasland]

See gh-104200 for an improvement. There's still stuff to be done, IMO. For example, return_converter (no underscore prefix!) is also hardcoded several places. There's also the hack mentioned by Brett in the OP.