Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PyDict_GetItem and PyObject_HasAttr should not be used #106033

Closed
serhiy-storchaka opened this issue Jun 23, 2023 · 3 comments
Closed

PyDict_GetItem and PyObject_HasAttr should not be used #106033

serhiy-storchaka opened this issue Jun 23, 2023 · 3 comments
Labels
type-bug An unexpected behavior, bug, or error

Comments

@serhiy-storchaka
Copy link
Member

serhiy-storchaka commented Jun 23, 2023 •
edited by bedevere-bot
Loading

These functions are broken by design, because they discard any exceptions raised inside, including MemoryError and KeyboardInterrupt. There were several rounds of getting rid of them in past (for example 567eba1, #11112, #75753), but they occur in new code.

Linked PRs
@serhiy-storchaka serhiy-storchaka added the type-bug An unexpected behavior, bug, or error label Jun 23, 2023
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this issue Jun 23, 2023
@serhiy-storchaka
pythongh-106033: Get rid of new occurrences of PyDict_GetItem and PyO…
c593435 
…bject_HasAttr

These functions are broken by design because they discard any exceptions raised
inside, including MemoryError and KeyboardInterrupt.  They should not be
used in new code.
@bedevere-bot bedevere-bot mentioned this issue Jun 23, 2023
Merged
@serhiy-storchaka serhiy-storchaka mentioned this issue Jun 23, 2023
Merged
serhiy-storchaka added a commit that referenced this issue Jun 23, 2023
@serhiy-storchaka
gh-106033: Get rid of new occurrences of PyDict_GetItem and PyObject_…
1d33d53 
…HasAttr (GH-106034)

These functions are broken by design because they discard any exceptions raised
inside, including MemoryError and KeyboardInterrupt.  They should not be
used in new code.
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this issue Jun 23, 2023
@serhiy-storchaka
[3.11] pythongh-106033: Get rid of new occurrences of PyDict_GetItem …
11c3096 
…and PyObject_HasAttr (pythonGH-106034)

These functions are broken by design because they discard any exceptions raised
inside, including MemoryError and KeyboardInterrupt.  They should not be
used in new code..
(cherry picked from commit 1d33d53)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
This was referenced Jun 23, 2023
Merged
Merged
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this issue Jun 23, 2023
@serhiy-storchaka
[3.12] pythongh-106033: Get rid of new occurrences of PyDict_GetItem …
4224df2 
…and PyObject_HasAttr (pythonGH-106034)

These functions are broken by design because they discard any exceptions raised
inside, including MemoryError and KeyboardInterrupt.  They should not be
used in new code.
(cherry picked from commit 1d33d53)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@serhiy-storchaka serhiy-storchaka mentioned this issue Jun 23, 2023
Merged
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this issue Jun 23, 2023
@serhiy-storchaka
pythongh-106033: Get rid of PyDict_GetItem in _PyFunction_FromConstru…
857ec72 
…ctor
This was referenced Jun 23, 2023
Merged
Merged
gpshead added a commit that referenced this issue Jun 24, 2023
@gpshead
gh-106033: [docs] Improve C API GetItem & HasAttr notes. (#106047)
19d6511 
Use a note:: tag so that these dict and object API deficiencies show up clearly.

A caution:: tag was considered, but our current python docs rendering doesn't do much with that (no box or color change).  warning:: seemed too extreme.  note looks good.
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jun 24, 2023
@gpshead @miss-islington
pythongh-106033: [docs] Improve C API GetItem & HasAttr notes. (pytho…
eabb664 
…nGH-106047)

Use a note:: tag so that these dict and object API deficiencies show up clearly.

A caution:: tag was considered, but our current python docs rendering doesn't do much with that (no box or color change).  warning:: seemed too extreme.  note looks good.
(cherry picked from commit 19d6511)

Co-authored-by: Gregory P. Smith <greg@krypto.org>
@bedevere-bot bedevere-bot mentioned this issue Jun 24, 2023
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jun 24, 2023
@gpshead @miss-islington
pythongh-106033: [docs] Improve C API GetItem & HasAttr notes. (pytho…
c191574 
…nGH-106047)

Use a note:: tag so that these dict and object API deficiencies show up clearly.

A caution:: tag was considered, but our current python docs rendering doesn't do much with that (no box or color change).  warning:: seemed too extreme.  note looks good.
(cherry picked from commit 19d6511)

Co-authored-by: Gregory P. Smith <greg@krypto.org>
@bedevere-bot bedevere-bot mentioned this issue Jun 24, 2023
Merged
gpshead added a commit that referenced this issue Jun 24, 2023
@miss-islington @gpshead
[3.11] gh-106033: [docs] Improve C API GetItem & HasAttr notes. (GH-1…
c69f29f 
…06047) (#106071)

gh-106033: [docs] Improve C API GetItem & HasAttr notes. (GH-106047)

Use a note:: tag so that these dict and object API deficiencies show up clearly.

A caution:: tag was considered, but our current python docs rendering doesn't do much with that (no box or color change).  warning:: seemed too extreme.  note looks good.
(cherry picked from commit 19d6511)

Co-authored-by: Gregory P. Smith <greg@krypto.org>
gpshead added a commit that referenced this issue Jun 24, 2023
@miss-islington @gpshead
[3.12] gh-106033: [docs] Improve C API GetItem & HasAttr notes. (GH-1…
746c0f3 
…06047) (#106070)

gh-106033: [docs] Improve C API GetItem & HasAttr notes. (GH-106047)

Use a note:: tag so that these dict and object API deficiencies show up clearly.

A caution:: tag was considered, but our current python docs rendering doesn't do much with that (no box or color change).  warning:: seemed too extreme.  note looks good.
(cherry picked from commit 19d6511)

Co-authored-by: Gregory P. Smith <greg@krypto.org>
gpshead pushed a commit that referenced this issue Jun 24, 2023
@serhiy-storchaka
[3.12] gh-106033: Get rid of new occurrences of PyDict_GetItem and Py… (
9cd3664 
#106041)

[3.12] gh-106033: Get rid of new occurrences of PyDict_GetItem and PyObject_HasAttr (GH-106034)

These functions are broken by design because they discard any exceptions raised
inside, including MemoryError and KeyboardInterrupt.  They should not be
used in new code.
(cherry picked from commit 1d33d53)
gpshead pushed a commit that referenced this issue Jun 24, 2023
@serhiy-storchaka
[3.11] gh-106033: Get rid of new occurrences of PyDict_GetItem and Py… (
dbe416b 
#106040)

[3.11] gh-106033: Get rid of new occurrences of PyDict_GetItem and PyObject_HasAttr (GH-106034)

These functions are broken by design because they discard any exceptions raised
inside, including MemoryError and KeyboardInterrupt.  They should not be
used in new code..
(cherry picked from commit 1d33d53)
serhiy-storchaka added a commit that referenced this issue Jun 29, 2023
@serhiy-storchaka
gh-106033: Get rid of PyDict_GetItem in _PyFunction_FromConstructor (G…
08c08d2 
…H-106044)
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jun 29, 2023
@serhiy-storchaka @miss-islington
pythongh-106033: Get rid of PyDict_GetItem in _PyFunction_FromConstru…
aba4a91 
…ctor (pythonGH-106044)

(cherry picked from commit 08c08d2)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot bedevere-bot mentioned this issue Jun 29, 2023
Merged
serhiy-storchaka added a commit that referenced this issue Jun 29, 2023
@miss-islington @serhiy-storchaka
[3.12] gh-106033: Get rid of PyDict_GetItem in _PyFunction_FromConstr…
e0fa531 
…uctor (GH-106044) (GH-106228)

gh-106033: Get rid of PyDict_GetItem in _PyFunction_FromConstructor (GH-106044)
(cherry picked from commit 08c08d2)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@iritkatriel iritkatriel mentioned this issue Jun 30, 2023
Closed
@iritkatriel
Copy link
Member

See also #86172.

@vstinner
Copy link
Member

See also the issue #106004: I propose adding PyDict_GetItemRef() function which doesn't have these flaws.

@erlend-aasland
Copy link
Contributor

Can this be closed, or do you expect more work here, @serhiy-storchaka?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@vstinner @iritkatriel @serhiy-storchaka @erlend-aasland