Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

importlib.resources.abc.TraversableResources says it is deprecated in favour of itself #105189

Closed
graingert opened this issue Jun 1, 2023 · 2 comments
Labels
3.12 bugs and security fixes 3.13 bugs and security fixes docs Documentation in the Doc dir easy topic-importlib

Comments

@graingert
Copy link
Contributor

graingert commented Jun 1, 2023

Documentation

https://docs.python.org/3.12/library/importlib.resources.abc.html#importlib.resources.abc.TraversableResources says it is deprecated in favour of itself

it should be documented here https://docs.python.org/3.12/library/importlib.html#module-importlib.abc

introduced in 10b12dd#r115987571

cc @jaraco @hugovk

Linked PRs

@graingert graingert added docs Documentation in the Doc dir 3.12 bugs and security fixes 3.13 bugs and security fixes labels Jun 1, 2023
@hugovk hugovk added the easy label Jun 1, 2023
@FFY00
Copy link
Member

FFY00 commented Jun 1, 2023

Yep, the warning should be in importlib.abc instead of importlib.resources.abc.

hugovk added a commit that referenced this issue Sep 13, 2023
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Sep 13, 2023
…GH-105232)

(cherry picked from commit 6c0ddca)

Co-authored-by: Thomas Grainger <tagrain@gmail.com>
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@hugovk
Copy link
Member

hugovk commented Sep 13, 2023

Fixed by #105232 and a pending backport. Thanks!

@hugovk hugovk closed this as completed Sep 13, 2023
Yhg1s pushed a commit that referenced this issue Sep 13, 2023
…5232) (#109363)

gh-105189: fix importlib.resources.abc deprecation docs (GH-105232)
(cherry picked from commit 6c0ddca)

Co-authored-by: Thomas Grainger <tagrain@gmail.com>
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
vstinner pushed a commit to vstinner/cpython that referenced this issue Sep 13, 2023
…#105232)

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.12 bugs and security fixes 3.13 bugs and security fixes docs Documentation in the Doc dir easy topic-importlib
Projects
None yet
Development

No branches or pull requests

4 participants