Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_typing fails refleak tests #104415

Closed
sobolevn opened this issue May 12, 2023 · 0 comments
Closed

test_typing fails refleak tests #104415

sobolevn opened this issue May 12, 2023 · 0 comments
Assignees
@sobolevn
Labels
tests Tests in the Lib/test dir topic-typing type-bug An unexpected behavior, bug, or error

Comments

@sobolevn
Copy link
Member

sobolevn commented May 12, 2023 •
edited by bedevere-bot
Loading

Repro: ./python.exe -m test -R 3:3 -v test_typing

The first test round passes, but the second one fails with:

======================================================================
FAIL: test_bytestring (test.test_typing.CollectionsAbcTests.test_bytestring)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/sobolev/Desktop/cpython/Lib/test/test_typing.py", line 6007, in test_bytestring
    with self.assertWarns(DeprecationWarning):
AssertionError: DeprecationWarning not triggered

----------------------------------------------------------------------
Ran 576 tests in 1.479s

FAILED (failures=1, skipped=1)
test test_typing failed
test_typing failed (1 failure)

I am working on a fix.

Linked PRs
@sobolevn sobolevn added type-bug An unexpected behavior, bug, or error tests Tests in the Lib/test dir topic-typing labels May 12, 2023
@sobolevn sobolevn self-assigned this May 12, 2023
sobolevn added a commit to sobolevn/cpython that referenced this issue May 12, 2023
@sobolevn
pythongh-104415: Fix refleak tests for typing.ByteString deprecation
e8f6c3d
@bedevere-bot bedevere-bot mentioned this issue May 12, 2023
Merged
@sobolevn sobolevn mentioned this issue May 12, 2023
Merged
JelleZijlstra pushed a commit that referenced this issue May 12, 2023
@sobolevn
gh-104415: Fix refleak tests for typing.ByteString deprecation (#10…
5b8cd5a 
…4416)
carljm added a commit to carljm/cpython that referenced this issue May 12, 2023
@carljm
Merge branch 'main' into supermon
8efd7c6 
* main:
  pythongh-91896: Fixup some docs issues following ByteString deprecation (python#104422)
  pythonGH-104371: check return value of calling `mv.release` (python#104417)
  pythongh-104415: Fix refleak tests for `typing.ByteString` deprecation (python#104416)
  pythonGH-86275: Implementation of hypothesis stubs for property-based tests, with zoneinfo tests (python#22863)
  pythonGH-103082: Filter LINE events in VM, to simplify tool implementation. (pythonGH-104387)
  pythongh-93649: Split gc- and allocation tests from _testcapimodule.c (pythonGH-104403)
  pythongh-104389: Add 'unused' keyword to Argument Clinic C converters (python#104390)
  pythongh-101819: Prepare _io._IOBase for module state (python#104386)
  pythongh-104413: Fix refleak when super attribute throws AttributeError (python#104414)
  Fix refleak in `super_descr_get` (python#104408)
  pythongh-87526: Remove dead initialization from _zoneinfo parse_abbr() (python#24700)
  pythongh-91896: Improve visibility of `ByteString` deprecation warnings (python#104294)
  pythongh-104371: Fix calls to `__release_buffer__` while an exception is active (python#104378)
  pythongh-104377: fix cell in comprehension that is free in outer scope (python#104394)
  pythongh-104392: Remove _paramspec_tvars from typing (python#104393)
  pythongh-104396: uuid.py to skip platform check for emscripten and wasi (pythongh-104397)
  pythongh-99108: Refresh HACL* from upstream (python#104401)
  pythongh-104301: Allow leading whitespace in disambiguated pdb statements (python#104342)
@JelleZijlstra JelleZijlstra mentioned this issue May 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sobolevn sobolevn

Labels
tests Tests in the Lib/test dir topic-typing type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sobolevn @AlexWaygood