Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link in code comment no longer relevant for HTML unescaping #100210

Closed
jcamiel opened this issue Dec 13, 2022 · 1 comment
Closed

Link in code comment no longer relevant for HTML unescaping #100210

jcamiel opened this issue Dec 13, 2022 · 1 comment
Assignees
@ezio-melotti
Labels
docs Documentation in the Doc dir

Comments

@jcamiel
Copy link
Contributor

jcamiel commented Dec 13, 2022 •
edited by bedevere-bot
Loading

Documentation

The link in

cpython/Lib/html/__init__.py

Line 28 in 0e081a0

# see http://www.w3.org/TR/html5/syntax.html#tokenizing-character-references
is not longer relevant and should be replace:

The link should explain the source of the replacements table:

# see http://www.w3.org/TR/html5/syntax.html#tokenizing-character-references

_invalid_charrefs = {
    0x00: '\ufffd',  # REPLACEMENT CHARACTER
    0x0d: '\r',      # CARRIAGE RETURN
    0x80: '\u20ac',  # EURO SIGN
    0x81: '\x81',    # <control>
    0x82: '\u201a',  # SINGLE LOW-9 QUOTATION MARK
    0x83: '\u0192',  # LATIN SMALL LETTER F WITH HOOK
    0x84: '\u201e',  # DOUBLE LOW-9 QUOTATION MARK
    0x85: '\u2026',  # HORIZONTAL ELLIPSIS
    0x86: '\u2020',  # DAGGER
    0x87: '\u2021',  # DOUBLE DAGGER
    0x88: '\u02c6',  # MODIFIER LETTER CIRCUMFLEX ACCENT
    0x89: '\u2030',  # PER MILLE SIGN
    0x8a: '\u0160',  # LATIN CAPITAL LETTER S WITH CARON

Linked PRs
@jcamiel jcamiel added the docs Documentation in the Doc dir label Dec 13, 2022
@jcamiel jcamiel changed the title Link in code no longer relevant Link in code comment no longer relevant for HTML unescaping Dec 13, 2022
@jcamiel jcamiel mentioned this issue Dec 13, 2022
Merged
@ezio-melotti ezio-melotti self-assigned this Dec 16, 2022
This was referenced Feb 19, 2023
Merged
Merged
ezio-melotti pushed a commit that referenced this issue Feb 19, 2023
@jcamiel
gh-100210: Correct the comment link for unescaping HTML (#100212)
9a07eff 
gh-100210: correct the comment link for unescaping HTML
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Feb 19, 2023
@jcamiel @miss-islington
pythongh-100210: Correct the comment link for unescaping HTML (python…
5ced514 
…GH-100212)

(cherry picked from commit 9a07eff)

Co-authored-by: Jean-Christophe Amiel <jeanchristophe.amiel@gmail.com>
pythongh-100210: correct the comment link for unescaping HTML
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Feb 19, 2023
@jcamiel @miss-islington
pythongh-100210: Correct the comment link for unescaping HTML (python…
5d4447e 
…GH-100212)

(cherry picked from commit 9a07eff)

Co-authored-by: Jean-Christophe Amiel <jeanchristophe.amiel@gmail.com>
pythongh-100210: correct the comment link for unescaping HTML
miss-islington added a commit that referenced this issue Feb 19, 2023
@miss-islington @jcamiel
gh-100210: Correct the comment link for unescaping HTML (GH-100212)
8520e6c 
(cherry picked from commit 9a07eff)

Co-authored-by: Jean-Christophe Amiel <jeanchristophe.amiel@gmail.com>
gh-100210: correct the comment link for unescaping HTML
carljm added a commit to carljm/cpython that referenced this issue Feb 20, 2023
@carljm
Merge branch 'main' into inlinecomp2
9f0fc5b 
* main: (60 commits)
  pythongh-102056: Fix a few bugs in error handling of exception printing code (python#102078)
  pythongh-102011: use sys.exception() instead of sys.exc_info() in docs where possible (python#102012)
  pythongh-101566: Sync with zipp 3.14. (pythonGH-102018)
  pythonGH-99818: improve the documentation for zipfile.Path and Traversable (pythonGH-101589)
  pythongh-88233: zipfile: handle extras after a zip64 extra (pythonGH-96161)
  pythongh-101981: Apply HOMEBREW related environment variables (pythongh-102074)
  pythongh-101907: Stop using `_Py_OPCODE` and `_Py_OPARG` macros (pythonGH-101912)
  pythongh-101819: Adapt _io types to heap types, batch 1 (pythonGH-101949)
  pythongh-101981: Build macOS as recommended by the devguide (pythonGH-102070)
  pythongh-97786: Fix compiler warnings in pytime.c (python#101826)
  pythongh-101578: Amend PyErr_{Set,Get}RaisedException docs (python#101962)
  Misc improvements to the float tutorial (pythonGH-102052)
  pythongh-85417: Clarify behaviour on branch cuts in cmath module (python#102046)
  pythongh-100425: Update tutorial docs related to sum() accuracy (FH-101854)
  Add missing 'is' to `cmath.log()` docstring (python#102049)
  pythongh-100210: Correct the comment link for unescaping HTML (python#100212)
  pythongh-97930: Also include subdirectory in makefile. (python#102030)
  pythongh-99735: Use required=True in argparse subparsers example (python#100927)
  Fix incorrectly documented attribute in csv docs (python#101250)
  pythonGH-84783: Make the slice object hashable (pythonGH-101264)
  ...
ezio-melotti added a commit that referenced this issue Feb 20, 2023
@miss-islington @jcamiel @ezio-melotti
[3.11] gh-100210: Correct the comment link for unescaping HTML (GH-10…
e9103e6 
…0212) (#102044)

gh-100210: Correct the comment link for unescaping HTML (GH-100212)
(cherry picked from commit 9a07eff)


gh-100210: correct the comment link for unescaping HTML

Co-authored-by: Jean-Christophe Amiel <jeanchristophe.amiel@gmail.com>
Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
@ezio-melotti
Copy link
Member

Fixed, thanks for the report and then PR!

carljm added a commit to carljm/cpython that referenced this issue Feb 22, 2023
@carljm
Merge branch 'main' into inlinecomp
544b30c 
* main: (225 commits)
  pythongh-102056: Fix a few bugs in error handling of exception printing code (python#102078)
  pythongh-102011: use sys.exception() instead of sys.exc_info() in docs where possible (python#102012)
  pythongh-101566: Sync with zipp 3.14. (pythonGH-102018)
  pythonGH-99818: improve the documentation for zipfile.Path and Traversable (pythonGH-101589)
  pythongh-88233: zipfile: handle extras after a zip64 extra (pythonGH-96161)
  pythongh-101981: Apply HOMEBREW related environment variables (pythongh-102074)
  pythongh-101907: Stop using `_Py_OPCODE` and `_Py_OPARG` macros (pythonGH-101912)
  pythongh-101819: Adapt _io types to heap types, batch 1 (pythonGH-101949)
  pythongh-101981: Build macOS as recommended by the devguide (pythonGH-102070)
  pythongh-97786: Fix compiler warnings in pytime.c (python#101826)
  pythongh-101578: Amend PyErr_{Set,Get}RaisedException docs (python#101962)
  Misc improvements to the float tutorial (pythonGH-102052)
  pythongh-85417: Clarify behaviour on branch cuts in cmath module (python#102046)
  pythongh-100425: Update tutorial docs related to sum() accuracy (FH-101854)
  Add missing 'is' to `cmath.log()` docstring (python#102049)
  pythongh-100210: Correct the comment link for unescaping HTML (python#100212)
  pythongh-97930: Also include subdirectory in makefile. (python#102030)
  pythongh-99735: Use required=True in argparse subparsers example (python#100927)
  Fix incorrectly documented attribute in csv docs (python#101250)
  pythonGH-84783: Make the slice object hashable (pythonGH-101264)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ezio-melotti ezio-melotti

Labels
docs Documentation in the Doc dir
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jcamiel @ezio-melotti