Make posix_openpt fd is non-inheritable.

By default all fds returned by Python APIs must be non-inheritable.
python · May 19, 2023 · f6dcd54 · f6dcd54
1 parent c99e91b
commit f6dcd54
Showing 1 changed file with 13 additions and 1 deletion.
diff --git a/Modules/posixmodule.c b/Modules/posixmodule.c
@@ -8060,9 +8060,21 @@ os_posix_openpt_impl(PyObject *module, int oflag)
 {
     int fd;
 
+#if defined(O_CLOEXEC)
+    oflag |= O_CLOEXEC;
+#endif
+
     fd = posix_openpt(oflag);
-    if (fd == -1)
+    if (fd == -1) {
         posix_error();
+        return -1;
+    }
+
+    // Just in case, likely a no-op given O_CLOEXEC above.
+    if (_Py_set_inheritable(fd, 0, NULL) < 0) {
+        close(fd);
+        return -1;
+    }
 
     return fd;
 }