Skip to content

Commit

Permalink
gh-92886: Replace assertion statements in handlers.BaseHandler to s…
Browse files Browse the repository at this point in the history
…upport running with optimizations (`-O`) (GH-93231)
  • Loading branch information
jackh-ncl authored Oct 19, 2022
1 parent a3be874 commit b6e59d7
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 3 deletions.
12 changes: 9 additions & 3 deletions Lib/wsgiref/handlers.py
Original file line number Diff line number Diff line change
Expand Up @@ -237,9 +237,7 @@ def start_response(self, status, headers,exc_info=None):
self.status = status
self.headers = self.headers_class(headers)
status = self._convert_string_type(status, "Status")
assert len(status)>=4,"Status must be at least 4 characters"
assert status[:3].isdigit(), "Status message must begin w/3-digit code"
assert status[3]==" ", "Status message must have a space after code"
self._validate_status(status)

if __debug__:
for name, val in headers:
Expand All @@ -250,6 +248,14 @@ def start_response(self, status, headers,exc_info=None):

return self.write

def _validate_status(self, status):
if len(status) < 4:
raise AssertionError("Status must be at least 4 characters")
if not status[:3].isdigit():
raise AssertionError("Status message must begin w/3-digit code")
if status[3] != " ":
raise AssertionError("Status message must have a space after code")

def _convert_string_type(self, value, title):
"""Convert/check value type."""
if type(value) is str:
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Replace ``assert`` statements with ``raise AssertionError()`` in :class:`~wsgiref.BaseHandler` so that the tested behaviour is maintained running with optimizations ``(-O)``.

0 comments on commit b6e59d7

Please sign in to comment.