Skip to content

Commit

Permalink
gh-103167: Fix -Wstrict-prototypes warnings by using (void) for f…
Browse files Browse the repository at this point in the history
…unctions with no args (GH-103168)
  • Loading branch information
sobolevn authored Apr 5, 2023
1 parent 1a8f862 commit 119f67d
Show file tree
Hide file tree
Showing 7 changed files with 16 additions and 16 deletions.
2 changes: 1 addition & 1 deletion Modules/_tkinter.c
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ Copyright (C) 1994 Steen Lumholt.
#define WAIT_FOR_STDIN

static PyObject *
_get_tcl_lib_path()
_get_tcl_lib_path(void)
{
static PyObject *tcl_library_path = NULL;
static int already_checked = 0;
Expand Down
4 changes: 2 additions & 2 deletions Modules/posixmodule.c
Original file line number Diff line number Diff line change
Expand Up @@ -8546,7 +8546,7 @@ os_setpgrp_impl(PyObject *module)
#include <processsnapshot.h>

static PyObject*
win32_getppid()
win32_getppid(void)
{
DWORD error;
PyObject* result = NULL;
Expand Down Expand Up @@ -13330,7 +13330,7 @@ static int has_ShellExecute = -1;
static HINSTANCE (CALLBACK *Py_ShellExecuteW)(HWND, LPCWSTR, LPCWSTR, LPCWSTR,
LPCWSTR, INT);
static int
check_ShellExecute()
check_ShellExecute(void)
{
HINSTANCE hShell32;

Expand Down
12 changes: 6 additions & 6 deletions PC/launcher.c
Original file line number Diff line number Diff line change
Expand Up @@ -449,7 +449,7 @@ locate_pythons_for_key(HKEY root, REGSAM flags)
}

static void
locate_store_pythons()
locate_store_pythons(void)
{
#if defined(_M_X64)
/* 64bit process, so look in native registry */
Expand All @@ -466,7 +466,7 @@ locate_store_pythons()
}

static void
locate_venv_python()
locate_venv_python(void)
{
static wchar_t venv_python[MAX_PATH];
INSTALLED_PYTHON * ip;
Expand Down Expand Up @@ -495,7 +495,7 @@ locate_venv_python()
}

static void
locate_all_pythons()
locate_all_pythons(void)
{
/* venv Python is highest priority */
locate_venv_python();
Expand Down Expand Up @@ -694,7 +694,7 @@ static wchar_t wrapped_script_path[MAX_PATH];
* valid wrapped script file.
*/
static void
locate_wrapped_script()
locate_wrapped_script(void)
{
wchar_t * p;
size_t plen;
Expand Down Expand Up @@ -1034,7 +1034,7 @@ read_config_file(wchar_t * config_path)
}
}

static void read_commands()
static void read_commands(void)
{
if (launcher_ini_path[0])
read_config_file(launcher_ini_path);
Expand Down Expand Up @@ -1684,7 +1684,7 @@ wcsdup_pad(const wchar_t *s, int padding, int *newlen)
}

static wchar_t *
get_process_name()
get_process_name(void)
{
DWORD bufferLen = MAX_PATH;
DWORD len = bufferLen;
Expand Down
6 changes: 3 additions & 3 deletions PC/launcher2.c
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ typedef BOOL (*PIsWow64Process2)(HANDLE, USHORT*, USHORT*);


USHORT
_getNativeMachine()
_getNativeMachine(void)
{
static USHORT _nativeMachine = IMAGE_FILE_MACHINE_UNKNOWN;
if (_nativeMachine == IMAGE_FILE_MACHINE_UNKNOWN) {
Expand Down Expand Up @@ -163,14 +163,14 @@ _getNativeMachine()


bool
isAMD64Host()
isAMD64Host(void)
{
return _getNativeMachine() == IMAGE_FILE_MACHINE_AMD64;
}


bool
isARM64Host()
isARM64Host(void)
{
return _getNativeMachine() == IMAGE_FILE_MACHINE_ARM64;
}
Expand Down
2 changes: 1 addition & 1 deletion Python/ceval_gil.c
Original file line number Diff line number Diff line change
Expand Up @@ -467,7 +467,7 @@ void _PyEval_SetSwitchInterval(unsigned long microseconds)
gil->interval = microseconds;
}

unsigned long _PyEval_GetSwitchInterval()
unsigned long _PyEval_GetSwitchInterval(void)
{
struct _gil_runtime_state *gil = &_PyRuntime.ceval.gil;
return gil->interval;
Expand Down
4 changes: 2 additions & 2 deletions Python/initconfig.c
Original file line number Diff line number Diff line change
Expand Up @@ -2355,13 +2355,13 @@ config_usage(int error, const wchar_t* program)
}

static void
config_envvars_usage()
config_envvars_usage(void)
{
printf(usage_envvars, (wint_t)DELIM, (wint_t)DELIM, PYTHONHOMEHELP);
}

static void
config_xoptions_usage()
config_xoptions_usage(void)
{
puts(usage_xoptions);
}
Expand Down
2 changes: 1 addition & 1 deletion Python/sysmodule.c
Original file line number Diff line number Diff line change
Expand Up @@ -1488,7 +1488,7 @@ static PyStructSequence_Desc windows_version_desc = {
};

static PyObject *
_sys_getwindowsversion_from_kernel32()
_sys_getwindowsversion_from_kernel32(void)
{
#ifndef MS_WINDOWS_DESKTOP
return NULL;
Expand Down

0 comments on commit 119f67d

Please sign in to comment.