Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry-picker: Run Travis CI test on Windows #311

Merged
merged 8 commits into from
Mar 16, 2019

Conversation

encukou
Copy link
Member

@encukou encukou commented Feb 22, 2019

I've set up a Windows build on Travis before, maybe I can help #296 a bit!
There's no Python pre-installed, but there's a package manager, choco, that can install it.

Currently, the tests fail because they seem to require Git's user.email and user.name to be set globally. They fail on my dev machine as well, since I don't have an e-mail set globally (I use different e-mail addresses on different repos).
Sadly, I can't devote time to fixing that issue, but I can help to reproduce or explain more if needed.

To try out changes privately, here's what I do:

  • Enable Travis on your fork of the repo
  • Uncheck "Build pused branches" and "Build pushed pull requests" on your fork's Travis settings (you'll want to trigger builds manually)
  • Push code you want to test to your fork's master branch
  • Use "Trigger build in Travis's "More options" menu to trigger the build
  • Cancel any builds you're not interested in (for example, all the Linux builds) to save both time and processing

.travis.yml Show resolved Hide resolved
.travis.yml Outdated Show resolved Hide resolved
@webknjaz
Copy link
Contributor

It should be easy to fix tests by extending this fixture (https://github.com/python/core-workflow/blob/b3c68fe/cherry_picker/cherry_picker/test.py#L87-L91) to set local user and email in config.

@encukou
Copy link
Member Author

encukou commented Feb 22, 2019

Oh, one more thing I meant to put in the initial comment:

Unfortunately I probably won't find much time to tend to this PR properly. Feel free to make changes directly to the branch, that'll make things much faster.

@webknjaz
Copy link
Contributor

Another thing is that Travis CI seems to be going down now: ansible/molecule#1770

.travis.yml Outdated Show resolved Hide resolved
@encukou encukou requested a review from Mariatta as a code owner March 15, 2019 18:43
@webknjaz
Copy link
Contributor

Git config related tests fixed. Now, there's two Unicode-related failures.

@webknjaz
Copy link
Contributor

@Mariatta please merge it, it's ready.

@Mariatta
Copy link
Member

Thanks!!

@Mariatta Mariatta merged commit 9cf0ac1 into python:master Mar 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants