Relax click dependency. #302
Conversation
Allow to install cherry_picker with the modern click version
|
Thanks! Do you need a release cut? |
|
It would be nice! |
|
Can you increase/update the version info, and the changelog? After that, create a GitHub tag of the release branch, and it will be automatically released to PyPI. There's a brief write-up here: https://github.com/python/core-workflow/tree/master/cherry_picker#publishing-to-pypi |
|
Will try |
|
v1.2.2 is now on PyPI |
| @@ -381,11 +381,11 @@ def check_repo(self): | |||
| help=("Path to config file, .cherry_picker.toml " | |||
| "from project root by default"), | |||
| default=None) | |||
| @click.argument('commit_sha1', 'The commit sha1 to be cherry-picked', nargs=1, | |||
There was a problem hiding this comment.
Why remove the explanation? How is this related to the click dependency update?
There was a problem hiding this comment.
Explicitly forbade meaningless argument actually. The help was never displayed IIRC
There was a problem hiding this comment.
Oh, nevermind. I've already figured out that it fails with this arg under newer Click: https://travis-ci.org/python/core-workflow/jobs/491106736#L270
Allow to install cherry_picker with the modern click version