Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the use of variables named async or await #455

Closed
cooperlees opened this issue Jun 30, 2017 · 2 comments · Fixed by #476
Closed

Remove the use of variables named async or await #455

cooperlees opened this issue Jun 30, 2017 · 2 comments · Fixed by #476

Comments

@cooperlees
Copy link

In Python 3.7 the use of async or await as variable names will cause errors as they are reserved keywords. Kazoo does this, we should get this fixed.

/data/users/cooper/binary#link-tree/kazoo/recipe/watchers.py:425: DeprecationWarning: 'async' and 'await' will become reserved keywords in Python 3.7

e.g.
https://github.com/python-zk/kazoo/blob/master/kazoo/recipe/watchers.py#L425-L427
@jeffwidman
Copy link
Member

@cooperlees Care to submit a PR for this?

@cooperlees
Copy link
Author

cooperlees commented Aug 1, 2017 •
edited
Loading

I've flagged this with our Zookeeper team. Hopefully someone there will. I'm strapped for time, just noticed this warning debugging a codebase that uses kazoo and thought I'd flag it.

tgockel added a commit to tgockel/kazoo that referenced this issue Aug 24, 2017
@tgockel
fix: Remove use of "async" as a variable
225d336 
The use of "async" and "await" as variable are deprecated in Python 3.7. This
patch removes the use of "async" (there is no usage of "await" to fix).

Closes python-zk#455
@tgockel tgockel mentioned this issue Aug 24, 2017
Merged
tgockel added a commit to tgockel/kazoo that referenced this issue Aug 30, 2017
@tgockel
fix: Remove use of "async" as a variable
4774404 
The use of "async" and "await" as variable are deprecated in Python 3.7. This
patch removes the use of "async" (there is no usage of "await" to fix).

Closes python-zk#455
@alanorth alanorth mentioned this issue Sep 25, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Remove use of "async" as a variable tgockel/kazoo
2 participants
@jeffwidman @cooperlees