Normalize path before hashing ... #4813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pendent of case on Windows
radoering
force-pushed
the
normalize-path-before-hashing-for-env-name
branch
from
18d7246
to
efa3d66
Compare
neersighted
approved these changes
Nov 23, 2021
Merged
3 tasks
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.... so that the generated venv name is independent of case on Windows
Pull Request Check List
Resolves #2419
Resolves #3829
Resolves #2161
Based on original PR #2421 with consent of its author
Normalizes the path before hashing so that the generated venv name is independent of case on Windows.
Without normalization, it is possible to unintentionally create multiple virtualenvs for the same path when (accidentally or due to certain tools) using an alternative spelling. It may also happen that an existing virtualenv is not found.
Attention: This change only affects Windows because os.path.normcase just returns the unchanged path on other operating systems (independent of the fact if the file system is case sensitive or not).