fix: Use importlib to invoke packaging.tags in Env #4749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neersighted
added
status/needs-consensus
neersighted
force-pushed
the
neersighted/tags-with-importlib
branch
from
314d275
to
4eac558
Compare
neersighted
force-pushed
the
neersighted/tags-with-importlib
branch
3 times, most recently
from
07aa90f
to
9fc53ab
Compare
neersighted
force-pushed
the
neersighted/tags-with-importlib
branch
from
9fc53ab
to
42cb46f
Compare
neersighted
force-pushed
the
neersighted/tags-with-importlib
branch
2 times, most recently
from
bab3908
to
53f367e
Compare
abn
force-pushed
the
neersighted/tags-with-importlib
branch
from
53f367e
to
a27c5a1
Compare
abn
force-pushed
the
neersighted/tags-with-importlib
branch
from
a27c5a1
to
dd5ac9f
Compare
abn
approved these changes
Apr 29, 2022
This was referenced May 15, 2022
Closed
2 tasks
Merged
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also re-implements #4362 and fixes #4264.
The
packagingversion change means that we will give up the ability for Poetry to manage Python 2.7 environments. Consensus is needed to determine if Python 2.7 is worth losing the ability to follow upstream.Additionally, this version restriction is a burden on downstreams who want to ship Poetry without bundled dependencies.