Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve package operations management #4336

Merged
merged 1 commit into from
Jul 31, 2021

Conversation

sdispater
Copy link
Member

This PR aims at improving the user experience when installing packages and at minimizing the install/uninstall operations when ignoring groups or opting-in groups.

An example of this is the following sequence:

$ poetry install
$ poetry install --without dev  # formerly --no-dev

It would remove the existing development packages which was counter-intuitive. Now, the existing development packages will be kept in the environment.

Any locked packages will be kept in the environment regardless of what is asked via the install command unless the --sync option is specified.

$ poetry install --without dev --sync
$ poetry install --only dev --sync

Overall, this should be less surprising for end users makes working with dependency groups easier.

Pull Request Check List

  • Added tests for changed code.
  • Updated documentation for changed code.

@sdispater sdispater added area/cli Related to the command line area/installer Related to the dependency installer area/ux Features and improvements related to the user experience labels Jul 31, 2021
@sdispater sdispater added this to the 1.2 milestone Jul 31, 2021
@sdispater sdispater force-pushed the improve-operations-transactions branch 2 times, most recently from 7176e5f to 6dce09c Compare July 31, 2021 21:22
@sdispater sdispater force-pushed the improve-operations-transactions branch from 6dce09c to ea8fb8c Compare July 31, 2021 21:47
@sdispater sdispater merged commit 1da3e72 into master Jul 31, 2021
@sdispater sdispater deleted the improve-operations-transactions branch July 31, 2021 22:09
@sdispater sdispater mentioned this pull request Jul 31, 2021
@a5r0n
Copy link

a5r0n commented Aug 9, 2021

👍🏻
#3957 and #3139 related

Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/cli Related to the command line area/installer Related to the dependency installer area/ux Features and improvements related to the user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants