Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle non-editable packages with pth files #3210

Merged
merged 1 commit into from
Oct 23, 2020

Conversation

abn
Copy link
Member

@abn abn commented Oct 14, 2020

When detecting installed packages, this change ensures that packages
with .pth files are not incorrectly marked as editable. A package is
considered editable only if at least one of the paths detected is
not in the environment site.

Resolves: #3077

@abn abn added the kind/bug Something isn't working as expected label Oct 14, 2020
@abn abn added this to the 1.1 milestone Oct 14, 2020
@abn abn requested a review from a team October 14, 2020 23:53
When detecting installed packages, this change ensures that packages
with .pth files are not incorrectly marked as editable. A package is
considered editable only if at least one of the paths detected is
not in the environment site.

Resolves: python-poetry#3077
@absassi
Copy link

absassi commented Oct 16, 2020

@abn, this works for me. Thanks.

@abn
Copy link
Member Author

abn commented Oct 17, 2020

@python-poetry/triage can I get this one reviewed please?

@sdispater sdispater merged commit 2e20673 into python-poetry:1.1 Oct 23, 2020
@abn abn deleted the issue/3077 branch October 23, 2020 09:40
Copy link

github-actions bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Something isn't working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants