Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes custom repositories with wrong precedence #2678

Closed
wants to merge 1 commit into from

Conversation

linw1995
Copy link

@linw1995 linw1995 commented Jul 16, 2020

Pull Request Check List

  • Added tests for changed code.
  • Updated documentation for changed code.
  1. If add any custom repository, its precedence will over PyPI.
  2. If not, there is only one repository PyPI.

So there is no point to make PyPI repository default.

The fixtures directory tests/fixtures/with_custom_source is just copied from tests/fixtures/with_default_source, and remove the default=true configuration from pyproject.toml file.

@finswimmer finswimmer requested a review from a team July 19, 2020 18:54
@neersighted
Copy link
Member

This is obsolete after the refactoring of the Repository code. If you think there is still value in this, please re-open the PR and rebase it/explain why the current behavior is incorrect. Thanks!

@neersighted neersighted closed this Jun 4, 2022
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

poetry does not prefer custom repository but docs say it does Private repos don't actually take precedence
2 participants