Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of dependency markers with python precision >= 3 #2526

Merged
merged 1 commit into from
Jun 9, 2020

Conversation

sdispater
Copy link
Member

@sdispater sdispater commented Jun 9, 2020

If a dependency was specifying a python condition with a python version with a precision of 3 or more (for instance, >=3.5,<3.5.4), it would generate an incorrect marker leading to issues while evaluating the marker against the environment.

For instance, the >=3.5,<3.5.4 condition would generate the following marker: python_version >= "3.5" and python_version < "3.5.4". However, the correct marker is: python_version >= "3.5" and python_full_version < "3.5.4".

Pull Request Check List

  • Added tests for changed code.
  • Updated documentation for changed code.

@sdispater sdispater added kind/bug Something isn't working as expected area/build-system Related to PEP 517 packaging (see poetry-core) area/installer Related to the dependency installer labels Jun 9, 2020
@sdispater sdispater merged commit dcc2e40 into master Jun 9, 2020
@sdispater sdispater deleted the fix-python-marker-handling branch June 9, 2020 18:56
Copy link

github-actions bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/build-system Related to PEP 517 packaging (see poetry-core) area/installer Related to the dependency installer kind/bug Something isn't working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant