Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a lightweight core library #2212

Merged
merged 4 commits into from
Mar 27, 2020
Merged

Use a lightweight core library #2212

merged 4 commits into from
Mar 27, 2020

Conversation

sdispater
Copy link
Member

Pull Request Check List

  • Added tests for changed code.
  • Updated documentation for changed code.

This PR extracts the core utilities of Poetry (like the building of distributions) into a separate package (poetry-core) that is lightweight and without any declared dependency, the dependencies are vendored instead.

This will help address the issues mentioned in #1993.

Fixes #1993

@sdispater sdispater marked this pull request as ready for review March 26, 2020 17:58
@@ -42,8 +42,8 @@ So, in your `pyproject.toml` file, add this section if it does not already exist

```toml
[build-system]
requires = ["poetry>=0.12"]
build-backend = "poetry.masonry.api"
requires = ["poetry-core>=1.0.0"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to have core somehow namespaced under poetry so that we will instead have requires = ["poetry.core>=1.0.0"]? Using a dash in the package name can be quite confusing, for example, when do we use the dash and the underscore (in docs/pyproject.md, it requires poetry_core).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both of these are equivalent to PyPI - so “_-” won't matter to PyPI. You can use poetry_core instead of poetry-core and they'll refer to the same thing in the dependency specification.

That's the interoperability standard (PEP 508/440) and I expect poetry follows it. :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah okay, good to know, thanks!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have preferred to use a namespace package but, as far as I know, it's not possible since poetry is already its own package.

It would require to no longer have the poetry package but multiple packages (like poetry-core and poetry-cli) so I don't think it's worth it for now.

However, if someone tells me there is a way to do it without big changes I'd be happy to change it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the end, I managed to make the poetry namespace work, so poetry-core will provide the poetry.core package.

Copy link

github-actions bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants