Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Append dependencies licenses #178

Merged
merged 2 commits into from
Dec 29, 2020
Merged

Conversation

radarhere
Copy link
Member

Suggestion for python-pillow/Pillow#4907

Adds a DEPENDENCIES_LICENSE file, that is appended onto Pillow's LICENSE file.

@hugovk
Copy link
Member

hugovk commented Dec 27, 2020

Thanks for the PR!

I suggest putting the licences as separate files with .txt extensions, in some subdirectory, to make them easier to inspect/update individually in the repo.

A command can still cat them all together at the end of the Pillow licence.

below, then obey all its terms and conditions when using FreeType 2 in
any of your projects or products.

- The FreeType License, found in the file `FTL.TXT', which is similar
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the files FTL.TXT and GPLv2.TXT referenced by FreeType be included as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know - the reader is instructed to pick one of them, so if we include both, then we're including a license that doesn't necessarily apply... which I think could be confusing.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be easy enough for people to find those files if they need them, and let's keep things simpler. We can add them if necessary later.

@hugovk hugovk merged commit 96283c0 into python-pillow:master Dec 29, 2020
@hugovk
Copy link
Member

hugovk commented Dec 29, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants