-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Ubuntu 24.04 #205
Added Ubuntu 24.04 #205
Conversation
Ignoring the failures for a moment, the build time for ubuntu-22.04-jammy-arm64v8 -> ubuntu-24.04-noble-arm64v8 is now very long: 26m -> 2h 3m. Let's stick with 22.04 for at least this one. For the manylinux ones:
Let's check those after merging so that image has been published. |
Ok. I've restored 22.04 arm64v8, and created python-pillow/Pillow#8024 to increase the timeout to allow valgrind to pass. |
Valgrind is now the slowest one and has increased from 1h9m to 1h30m with 24.04. Let's stay on 22.04 a bit longer there too. |
Ok, done. |
Thanks! This maybe wasn't very clear:
I meant: let's revert these, merge, and do those in a followup. So we can make sure they pass before merging. |
Thank you very much! |
Ubuntu 24.04 has been released - https://releases.ubuntu.com/noble/
Transitioning to the new Ubuntu meant updating to Python 3.12, and adding libxcb-shape0 for PySide6, but also, an error started appearing from
addgroup pillow sudo
https://github.com/radarhere/docker-images/actions/runs/8857703276/job/24325472410#step:6:2293
Removing the command then led to a permission error during install - it turns out that our use of 1000 as the pillow user id
docker-images/.github/workflows/build.yml
Line 72 in 03bcc46
doesn't work on Ubuntu 24.04. It has moved from 1000 to 1001. To be consistent, I've updated all images to use 1001.