Nitpicks

[manisandro]

Just some trivial fixes for things rpmlint complains about:

• Jpeg2KEncode.c should not be executable
• OleFileIO.py should not have a shebang since it is not an executable python script
• WalImageFile.py should be utf-8 encoded

[hugovk]

OleFileIO.py has an if __name__ == "__main__": section so is executable as a standalone script, even though Pillow doesn't use it that way.

Also, I'm not sure if we're taking changes to OleFileIO.py as it's also maintained elsewhere, but having said that we have made some changes recently which should probably be contributed back upstream, so I'll leave this to the other project members to decide. This also concerns PR #931.

[manisandro]

Oh yes I missed the if __name__ == "__main__":. In that case, we could just make the file executable (and fix the shebang along the way to use /usr/bin/env python like the other scripts).

[hugovk]

@wiredfool @aclark4life Are we ok to take changes for OleFileIO.py? See also #931.

[aclark4life]

+0, although if it's just nitpicks with no serious consequences then +1 for sure.

[wiredfool]

I don't think the changes to OleFileIO are going to lead to messy merges with Philippe's future changes. So, fine with me.

[hugovk]

Thanks!

[decalage2]

Hi, I am not sure why the encoding declaration in OleFileIO is an issue, but removing it should be fine. However, according to PEP 0263, the absence of encoding declaration means the encoding is "ascii" (7-bits), and not UTF-8 as mentioned in commit 0ca102f. If UTF-8 is preferred, I think it should be explicit with an encoding declaration.
I will merge these changes (shebang + coding) into the new version of olefile that I am preparing, then I will submit a pull request.

[manisandro]

My bad, thanks for spotting.

[hugovk]

Thanks @decalage2!