-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upload wheels to scientific-python-nightly-wheels index #8236
Conversation
Your original idea was |
Thanks for the pointer @radarhere! Updated now. |
For my curiosity - can this be removed once Python 3.13 final is released on October 1? |
Hmm, that's a good question. Many people will start testing only after the final release, so we'll have free-threading-related bugfixes after that as well, and nightlies will continue to be helpful then. So my feeling is that we can go on uploading nightlies after final and only stop when threading-related bug reports start slowing down significantly. What do you think? |
Co-authored-by: Andrew Murray <radarhere@users.noreply.github.com>
# │ │ │ ┌───────────── month (1 - 12 or JAN-DEC) | ||
# │ │ │ │ ┌───────────── day of the week (0 - 6 or SUN-SAT) | ||
# │ │ │ │ │ | ||
- cron: "42 1 * * 0,3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The wheels build takes up a fair amount of CI time/runners.
@radarhere Is 01:42 UTC going to interfere with when you're active? We can move it to your night/inactive time if you like.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the thought, but that's not a problem for me personally - especially since d83c7b3 skips the aarch64 jobs.
Yes, I think it will be helpful too. |
Will do! Stay tuned … |
@hugovk And … can't find my secret key or emergency kit, can you please start a recovery for me and I'll be sure to save this time? Sorry about that. |
Done!
|
Thanks, also done! Do we still need any/all of the other secrets ? ![]() I have an Anaconda Cloud account too: https://anaconda.org/aclark |
Pillow/.github/workflows/test.yml Line 163 in 86f4cfb
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reran the wheels job thinking it would make use of the new secret, but I forgot that it was only used by workflow dispatch and schedule.
I guess merging and seeing if this works is the next step.
Let's try it! Edit: manually triggered: https://github.com/python-pillow/Pillow/actions/runs/9975952588 |
It seems that the QEMU job was started as well. Opened #8243 to fix that. Does it make sense to stop everything and rerun it after that follow-up PR has been merged as well? |
Yes, let's save two hours of CI time, I've cancelled it. |
#8243 is merged, here's a new run: https://github.com/python-pillow/Pillow/actions/runs/9978963564 |
Related to #8199.
In order for this to work we're going to need a secret named
PILLOW_NIGHTLY_UPLOAD_TOKEN
. @hugovk Did you already create it? If so, what's its name?