Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use BreakBeforeBraces: Linux for clang-format #8212

Closed

Conversation

homm
Copy link
Member

@homm homm commented Jul 7, 2024

Rationale

It's extremely hard to distinguish function arguments from local variables:

void static inline ImagingLineBoxBlur32(
    pixel *lineOut,
    pixel *lineIn,
    int lastx,
    int radius,
    int edgeA,
    int edgeB,
    UINT32 ww,
    UINT32 fw) {
    int x;
    UINT32 acc[4];
    UINT32 bulk[4];
static union hist_extrema *
parse_histogram_extremap(
    ImagingObject *self, PyObject *extremap, union hist_extrema *ep) {
    int i0, i1;
    double f0, f1;

After proposition:

void static inline ImagingLineBoxBlur32(
    pixel *lineOut,
    pixel *lineIn,
    int lastx,
    int radius,
    int edgeA,
    int edgeB,
    UINT32 ww,
    UINT32 fw)
{
    int x;
    UINT32 acc[4];
    UINT32 bulk[4];
static union hist_extrema *
parse_histogram_extremap(
    ImagingObject *self, PyObject *extremap, union hist_extrema *ep)
{
    int i0, i1;
    double f0, f1;

@radarhere
Copy link
Member

#8067 would seem like an alternative suggestion. I'm guessing you prefer this?

@homm
Copy link
Member Author

homm commented Jul 8, 2024

I'm guessing you prefer this?

Actually, no! I haven't seen #8067 and like it more.

@homm homm closed this Jul 8, 2024
@homm homm deleted the clang-format-linux-braces branch July 8, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants