Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept 't' suffix for libtiff version #8126

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Accept 't' suffix for libtiff version #8126

merged 1 commit into from
Jun 10, 2024

Conversation

radarhere
Copy link
Member

The docker-images alpine build has started failing - https://github.com/python-pillow/docker-images/actions/runs/9444260430/job/26009462397

FAILED Tests/test_features.py::test_version - AssertionError: assert ('4.6.0t' is None or None)

This is because the libtiff version on alpine has been changed to 4.6.0t - https://git.alpinelinux.org/aports/commit/?id=7f743c559b40c7e47561f032b2cae50681e362fc

So, like #8009, let's update the tests to allow for the suffix.

@hugovk hugovk merged commit 444faa2 into python-pillow:main Jun 10, 2024
52 of 55 checks passed
@nulano
Copy link
Contributor

nulano commented Jun 10, 2024

FWIW, it seems that 4.6.0t is a fork: https://www.asmail.be/msg0054918507.html

@radarhere radarhere deleted the libtiff_version branch June 10, 2024 20:51
@radarhere radarhere mentioned this pull request Jun 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Linux Testing TIFF
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@radarhere @nulano @hugovk