Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate support for libtiff < 4 #7998

Merged
merged 4 commits into from
Apr 22, 2024
Merged

Conversation

radarhere
Copy link
Member

libtiff 4.0 was released on 21st December 2011, 12 years ago.

I'm hoping that's long enough to not require a deprecation period for removing support for libtiff < 4.

@radarhere radarhere added the TIFF label Apr 21, 2024
@hugovk
Copy link
Member

hugovk commented Apr 22, 2024

And looks like the last v3 release was v3.9.7, released in 2012:

If we make an exception to "at least one year of deprecation", I suggest we at least deprecate in Pillow 10.4.0 (July) and remove in 11.0.0 (October). I'd rather play it safe, so there's some warning period, and we still remove it in a SemVer major bump.

@radarhere radarhere added the Deprecation Feature that will be removed in the future label Apr 22, 2024
@radarhere radarhere changed the title Removed support for libtiff < 4 Deprecate support for libtiff < 4 Apr 22, 2024
@radarhere
Copy link
Member Author

radarhere commented Apr 22, 2024

If we're playing it safe, then I'm happy enough to just keep the normal 1 year minimum deprecation.

I've updated the commit to deprecate in Pillow 12.

Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, let's also add to the 10.4.0 release notes.

docs/deprecations.rst Outdated Show resolved Hide resolved
docs/deprecations.rst Outdated Show resolved Hide resolved
radarhere and others added 3 commits April 22, 2024 19:14
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@hugovk hugovk merged commit 37a8364 into python-pillow:main Apr 22, 2024
52 checks passed
@radarhere radarhere deleted the libtiff_v3 branch April 22, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deprecation Feature that will be removed in the future TIFF
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants