Removed __future__ import from fuzz_font.py and fuzz_pillow.py
#7649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the short/medium term is to remove them. A better fix would be if they inserted after any But then these are test files so it's not so important to type them, there's not much in these files, and if we did type we could use non-future stuff. Thanks for the following up! |
radarhere
changed the title
__future__ import from fuzz_font.py and fuzz_pillow.py
|
This worked. https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=65341 is now closed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps #2625.
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=65341 is still open, complaining that
from __future__ imports must occur at the beginning of the file, despite #7637 moving the imports.I asked about this at google/oss-fuzz#11415, and was told that oss-fuzz prepends code to the files.
I think the solution here is to just remove
from __future__ import annotationsfrom fuzz_font.py and fuzz_pillow.py. I've tested it in my oss-fuzz fork, and it fails without this, but passes with.