Convert colormap hex values to RGB beforehand instead of on demand #7632
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
colormap
dictionary maps color names to hex values.Pillow/src/PIL/ImageColor.py
Lines 161 to 166 in bfbfff0
When it is used, the hex values is converted to an RGB tuple. That value is then saved back to
colormap
, as a way of caching the conversion to RGB.Pillow/src/PIL/ImageColor.py
Lines 40 to 45 in bfbfff0
It would be more efficient to always have the RGB values stored in the code. This also makes
colormap
consistent, rather than changing during runtime.