Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install cibuildwheel from requirements file #7581

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Nov 27, 2023

Helps #7390.

Switch back to the PyPI-installed cibuildwheel for GitHub Actions, also use it from Travis CI.

The upcoming Windows wheel build can't use the action, so Renovate can update all three at the same time.

.github/renovate.json Outdated Show resolved Hide resolved
},
{
"groupName": "requirements-cibw.txt",
"matchFileNames": [".ci/requirements-cibw.txt"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure that renovate won't handle this automatically? https://docs.renovatebot.com/modules/manager/pip_requirements/#file-matching

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure. Shall we leave this file as is, and check when the next release comes out?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we'd need to wait until the next release. I think if we merged the PR without this change, then we could see if #6604 started listing the file or not.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to this file dropped.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, now that this is merged, it's there!

So Renovate can update them all at the same time
@radarhere radarhere merged commit 697c24b into python-pillow:main Nov 28, 2023
62 checks passed
@hugovk hugovk deleted the requirements-cibw branch November 28, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants