Do not raise an error if os.environ does not contain PATH #6935

radarhere · 2023-02-09T21:12:37Z

Resolves #6934

Lines 245 to 249 in 7e3bed6

    
           def _cmd_exists(cmd): 
        
               return any( 
        
                   os.access(os.path.join(path, cmd), os.X_OK) 
        
                   for path in os.environ["PATH"].split(os.pathsep) 
        
               )

presumes that os.environ contains a "PATH" key.

This PR changes the code no longer raise an error if it doesn't.

setup.py

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>

Do not raise an error if os.environ does not contain PATH

5059e5c

hugovk reviewed Mar 12, 2023

View reviewed changes

setup.py Outdated Show resolved Hide resolved

Use type hint

7670736

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>

hugovk added the automerge Automatically merge PRs that are ready label Mar 12, 2023

hugovk approved these changes Mar 12, 2023

View reviewed changes

radarhere merged commit 5b3d39c into python-pillow:main Mar 12, 2023

radarhere deleted the path branch March 12, 2023 13:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Do not raise an error if os.environ does not contain PATH #6935

Do not raise an error if os.environ does not contain PATH #6935

radarhere commented Feb 9, 2023 •

edited

Loading

	def _cmd_exists(cmd):
	return any(
	os.access(os.path.join(path, cmd), os.X_OK)
	for path in os.environ["PATH"].split(os.pathsep)
	)

Do not raise an error if os.environ does not contain PATH #6935

Do not raise an error if os.environ does not contain PATH #6935

Conversation

radarhere commented Feb 9, 2023 • edited Loading

radarhere commented Feb 9, 2023 •

edited

Loading