Support custom comments and PLT markers when saving JPEG2000 images #6903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radarhere
reviewed
Jan 19, 2023
Co-authored-by: Andrew Murray <3112309+radarhere@users.noreply.github.com>
Could you elaborate on this? What are some example of the 'ancient image viewers'? Also, it's required for old image viewers, but the option was only added to OpenJPEG two years ago? |
radarhere
reviewed
Jan 19, 2023
|
Well, it's technically one image viewer I'm referring to, it's called 'RICS' and it's used in Pathology and It's built on the Kadaku library. So I've been needing to integrate with/replace it with something more modern. |
Co-authored-by: Andrew Murray <3112309+radarhere@users.noreply.github.com>
radarhere
reviewed
Jan 25, 2023
radarhere
reviewed
Jan 25, 2023
|
I didn't think that "add_" was necessary, so I've renamed "add_plt" to just "plt". |
hugovk
reviewed
Mar 27, 2023
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
radarhere
changed the title
radarhere
changed the title
radarhere
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Adds two new options when saving JPEG2000 images.
commentparameter to the save function replaces the default "Created by OpenJPEG version" with a given string.add_pltparameter includes a PLT marker segment codestream, which is required for some ancient image viewers.