-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenJpeg 2.1 #681
OpenJpeg 2.1 #681
Conversation
Still failing on PPC |
Should I manually merge this? |
I wanted to check on windows, but I'm having trouble getting Pillow to build with any of the any of the openjpegs there. |
@wiredfool Maybe @cgohlke can help |
This has been merged to pre-unittest conversion. I'd still like to get some successful testing done on windows. |
Did battle a bit more with windows, and I can't get it to link with openjpeg at all, either compiling the lib or using the prebuilt binaries, zip file or installer. |
I just tried
As usual I do override all the PIL feature detection and hard code it for my build environment in setup.py:
All libraries are static. The headers and libraries can be found in %INCLUDE% and %LIB% (or %INCLIB% on my system). I build openjpeg with cmake:
|
@cgohlke: My problem is more that I'm not at a stable working windows build yet than this patch. With your confirmation and what I've tested locally, I think this one is good to merge. |
Thanks @cgohlke and @wiredfool |
Includes #675.