Expanded .ani and .cur functionality #6606
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
Turns out it was much easier to implement .cur file saving (as it shares a lot with ICO). So I remodified CurImagePlugin to add that functionality. I reverted the BmpImagePlugin changes. |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
radarhere
changed the title
for more information, see https://pre-commit.ci
jlwoolf
changed the title
|
Alright, made some significant modifications. I believe I have mostly resolved all the .cur file issues, but tests need to be written for a few. I have also further expanded this functionality to work with .ani files. You can now read and write them. I also plan to work on tests for them in the future. |
Tests/test_file_cur.py
Outdated
| def test_deerstalker(): | ||
| with Image.open("Tests/images/cur/deerstalker.cur") as im: |
There was a problem hiding this comment.
Any particular reason for this change?
There was a problem hiding this comment.
I moved all the .cur files into a folder so that the Images folder was not cluttered by the ones I planned to add. At the same time I decided to rename the test since I was about to test a few more cursors (from windows 98 and up)
Co-authored-by: Andrew Murray <3112309+radarhere@users.noreply.github.com>
|
@radarhere |
|
Oh, this apparently seems to be similar to my work in #6965 and https://github.com/akx/Pillow/tree/cur-support... |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Currently the BmpImagePlugin checks if a file is a .cur file by checking if the bits are 32 and a the header is 22. However, the header for cursor files is not guaranteed to be 22.
The CurImagePlugin selects the largest cursor image from the file. The largest cursor does not have to be at the front of the file. So the start of the DIB header file varies depending on the file.
The fix below initializes a parameter in the CurImagePlugin (if it is in fact a .cur file) so that transparency is considered. It might be worth modifying CurImagePlugin to work similarly to IcoImagePlugin however. I'm looking into that right now, but this is a simple fix.