Ensure Tkinter hook is activated for getimage() #6032
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6020
When
PhotoImage.paste
calls "PyImagingPhoto", it catches a TclError in case the tkinter hooks have not been activated yet. If they haven't, then it calls_imagingtk.tkinit
, which callsTkImaging_Init
, which creates the "PyImaging" Tcl commands.ImageTk.getimage
does not handle the situation where the tkinter hooks have not been activated yet.Pillow/src/PIL/ImageTk.py
Lines 274 to 281 in ab8125f
So the user from the issue has reported a TclError being raised. This was missed in #3814.
As for testing this, although
test_photoimage()
looks like it is only testinggetimage()
, whenPhotoImage
is called with an image as the first argument, it callspaste
immediately. In contrast, the test that I've modified just callsgetimage()
, and so when the test suite is run in reverse, this will be called first.