Upload image errors to GitHub Actions #4135
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As GitHub Actions allows direct artifact uploads, failed image comparisons can now be uploaded directly, instead of using an external server (unlike in #2862).
The failed comparisons are saved in a randomly named directory (from
tempfile.mdktemp
), which is then uploaded in an artifact namederrors.zip
.Test Docker is not included in this, as this is a bit more complicated there.
Sample commit with failing test: nulano@165d457
Test (Ubuntu and macOS): https://github.com/nulano/Pillow/runs/257598825
Test Windows: https://github.com/nulano/Pillow/runs/257598798