Fix OpenSuse >= 15 support #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make distro.id() report newer versions of OpenSuSE (at least >=15) also report as opensuse. They report themselves as opensuse-leap.
hartwork
approved these changes
Oct 25, 2021
HorlogeSkynet
approved these changes
Oct 27, 2021
HorlogeSkynet
pushed a commit
that referenced
this pull request
Jun 7, 2022
HorlogeSkynet
pushed a commit
that referenced
this pull request
Jun 21, 2022
This was referenced Nov 10, 2022
jmellorcrummey
pushed a commit
to HPCToolkit/hpctoolkit
that referenced
this pull request
Apr 9, 2023
We aren't using Spack (heavily) in these images, all we use it for is to install from the buildcache. Spack doesn't need to know about *all* the compilers we installed to do that much. This also fixes an issue regarding the Spack code for OpenSUSE Leap 15, it used to be called `os=opensuse_leap15` but now is `os=opensuse15`. Bisection reveals the difference appeared when the distro vendered dependency was updated in spack/spack#33951 to include python-distro/distro#319. The change in Spack occured in January 2023, years after the change in distro was merged in October 2021, over a year after OpenSUSE Leap 15.2 was released in July 2020. Sigh.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
distro.id()report newer versions of OpenSuSE (at least >=15) also report asopensuse. They report themselves asopensuse-leap.