Fix incorrect Self import from typing instead of typing_extensions

pytest-dev · Aug 27, 2024 · e628783 · e628783
1 parent 05c43af
commit e628783
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 3 deletions.
diff --git a/changelog/12744.bugfix.rst b/changelog/12744.bugfix.rst
@@ -0,0 +1 @@
+Replaced `typing.Self` with `typing_extensions.Self` -- by :user:`Avasam`
diff --git a/src/_pytest/doctest.py b/src/_pytest/doctest.py
@@ -44,7 +44,8 @@
 
 if TYPE_CHECKING:
     import doctest
-    from typing import Self
+
+    from typing_extensions import Self
 
 DOCTEST_REPORT_CHOICE_NONE = "none"
 DOCTEST_REPORT_CHOICE_CDIFF = "cdiff"

diff --git a/src/_pytest/nodes.py b/src/_pytest/nodes.py
@@ -43,7 +43,7 @@
 
 
 if TYPE_CHECKING:
-    from typing import Self
+    from typing_extensions import Self
 
     # Imported here due to circular import.
     from _pytest.main import Session

diff --git a/src/_pytest/python.py b/src/_pytest/python.py
@@ -78,7 +78,7 @@
 
 
 if TYPE_CHECKING:
-    from typing import Self
+    from typing_extensions import Self
 
 
 def pytest_addoption(parser: Parser) -> None: