-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support timeout trigger skip instead of fail #153
Support timeout trigger skip instead of fail #153
Conversation
Support timeout trigger skip instead of fail
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why skip?
The rationale is because I use Currently, what is possible in Thus, I need |
Thanks for giving more rationale. I'm currently leaning against this I'm afraid. The current philosophy of pytest-timeout is that timeouts are fatal and need to be debugged. You seem to use it as some kind of "i don't care enough about the results to wait longer" if I understand correctly (I might not have understood correctly!), which I'm not really keen to add more features to pytest-timeout for. |
It's more like that "let skip that for now". Skip is different from success, it works like a warning. Or, I need to change the notebook itself, like comments all cells below the long run cell and tell user to uncomment those cells to run the example. |
From my pov having it xfail would be a stretch, but Skip ain't acceptable Even then, xfail should not available as global configuration by default, but rather as context manager |
This is an initial PR for support timeout that trigger skip instead of fail. If this concept is accepted, I'm willing to add pytest and doc. Thank you.