Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplication of markers in async tests #838

Merged
merged 2 commits into from
Jul 8, 2024

Conversation

seifertm
Copy link
Contributor

Fixes #813

…ewriteWarning.

Signed-off-by: Michael Seifert <m.seifert@digitalernachschub.de>
@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.08%. Comparing base (65aa441) to head (d15c9fc).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #838      +/-   ##
==========================================
- Coverage   95.61%   92.08%   -3.54%     
==========================================
  Files           2        2              
  Lines         479      480       +1     
  Branches       96       96              
==========================================
- Hits          458      442      -16     
- Misses         12       23      +11     
- Partials        9       15       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seifertm seifertm marked this pull request as ready for review July 4, 2024 08:32
@seifertm seifertm added this to the v0.23 milestone Jul 4, 2024
… functions.

Signed-off-by: Michael Seifert <m.seifert@digitalernachschub.de>
@seifertm seifertm added this pull request to the merge queue Jul 8, 2024
Merged via the queue into pytest-dev:main with commit b646cc1 Jul 8, 2024
14 checks passed
@seifertm seifertm deleted the fix-duplicate-markers branch July 8, 2024 12:54
@MeggyCal
Copy link

MeggyCal commented Jul 9, 2024

Thank you for a quick fix! Alas, it didn't fix the bokeh testsuite (at least in my environment).

@seifertm
Copy link
Contributor Author

@MeggyCal Can you provide a small code example that reproduces the issue?
Ideally, this should go into a separate issue.

@MeggyCal
Copy link

Sorry, not easily, I can try next week. Anyway, it is visible in my project on the openSUSE Buildservice: https://build.opensuse.org/project/show/home:mcalabkova:branches:devel:languages:python:numeric

@seifertm
Copy link
Contributor Author

@MeggyCal A quick look at the logs suggest that the tests due to the following warning:

pytest.PytestWarning: The test […] is marked with '@pytest.mark.asyncio' but it is not an async function. Please remove the asyncio mark. If the test is not marked explicitly, check for global marks applied via 'pytestmark'.

The warning is most likely unrelated to this PR and probably not a bug either, because the warning exists for some time already.

Whether the warning is reasonable or not is an entirely different issue. I'm open for discussing this in a dedicated issue or discussion :)

@MeggyCal
Copy link

@seifertm I took a look in the bokeh issues and found out it is a known issue since December: bokeh/bokeh#13578. So it is merely a consequence of openSUSE not upper-bounding dependencies and there's no need to open another issue.

Sorry for the false alarm, I just looked into this repo first and since I saw a fix for a similar-sounding issue, I didn't investigate further and just assumed wrong. Thank you very much for your help!

@seifertm
Copy link
Contributor Author

Thanks for the investigation, @MeggyCal !
I hope that we can get rid of the blockers soon, which prevent users from upgrading from v0.21…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iter_markers_with_node() has double entries for async test functions
3 participants