Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for, and suppress, additional get_event_loop() DeprecationWarnings #817

Merged
merged 12 commits into from
May 14, 2024
Merged

Test for, and suppress, additional get_event_loop() DeprecationWarnings #817

merged 12 commits into from
May 14, 2024

Conversation

SyntaxColoring
Copy link
Contributor

@SyntaxColoring SyntaxColoring commented Apr 18, 2024

This attempts to do what's described in #757 (comment), to solve continued instances of issue #757:

  • Add tests to catch any lingering asyncio.get_event_loop() DeprecationWarnings.
    • The existing tests are already catching a bunch, but only when they're run under specific Python patch versions. So the test part of this PR just configures tox and GitHub Actions to do that.
    • I could only reproduce the warnings on specific Python 3.10.x patch versions, and I couldn't easily get CI to use those versions, so we don't have tests for this.
  • Suppress those warnings.

@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.59%. Comparing base (dfe6e7c) to head (8f9388f).
Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #817   +/-   ##
=======================================
  Coverage   95.59%   95.59%           
=======================================
  Files           2        2           
  Lines         477      477           
  Branches       96       95    -1     
=======================================
  Hits          456      456           
  Misses         12       12           
  Partials        9        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tox.ini Outdated Show resolved Hide resolved
I don't think this matters, but maybe...
Copy link
Contributor

@seifertm seifertm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for looking into this!

tests/async_fixtures/test_async_fixtures_with_finalizer.py Outdated Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
@SyntaxColoring SyntaxColoring marked this pull request as draft April 23, 2024 18:49
We can only reproduce this on specific Python 3.10.x patch versions, but we can't easily test those in CI. Give up the attempt.
@SyntaxColoring SyntaxColoring marked this pull request as ready for review April 25, 2024 22:27
@SyntaxColoring
Copy link
Contributor Author

@seifertm Ping—do the latest changes address your feedback?

Signed-off-by: Michael Seifert <m.seifert@digitalernachschub.de>
Copy link
Contributor

@seifertm seifertm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They do. Thank you for the patch.

I'll aim for a release this week.

@seifertm seifertm enabled auto-merge May 14, 2024 17:19
@seifertm seifertm added this pull request to the merge queue May 14, 2024
Merged via the queue into pytest-dev:main with commit 3bd9cd8 May 14, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants