Update spatial.py #205
Merged
Update spatial.py #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chuwenhao123 can you please make a quick commit and bump down the Pillow version number required so we can get this to pass? |
|
Hello @bemcdonnell, I observed that you may not have direct control over the Pillow version, as shown in the image below. On my own computer, I utilized the swmmio.draw_model function with Pillow version 9.5, and it worked perfectly. "I plan to attempt committing a compatible version at a later time. |
|
Hi @bemcdonnell, I've managed to control the PILLOW version in the requirements.txt file. I hope this resolves the issue. |
|
@karosc, nice work on SWMM-toolkit. I retriggered the build (from the beach 🏖️) and things are looking good. We obviously need to circle back to see if we need to deprecate pillow or move to v10. |
bemcdonnell
approved these changes
Sep 28, 2023
aerispaha
approved these changes
Sep 28, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed that written polygon shapefile may be not correctly loaded in ArcGIS