Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize multiple checks with caching #35

Merged
merged 4 commits into from
Jun 20, 2023

Conversation

ArtyomVancyan
Copy link
Member

Motivation:

As the information about the client's device is parsed from a user agent, it should only check once for a particular client.

With the current changes it checks the device once at the beginning of the session and if the user agent has changed somehow. And this will improve the performance of a single request.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you updated the documentation related to the changes you have made?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

@ArtyomVancyan ArtyomVancyan marked this pull request as ready for review June 20, 2023 15:08
@ArtyomVancyan ArtyomVancyan changed the title Optimize miltiple checks with caching Optimize multiple checks with caching Jun 20, 2023
@ArtyomVancyan ArtyomVancyan merged commit 70b1239 into pysnippet:master Jun 20, 2023
15 checks passed
@ArtyomVancyan ArtyomVancyan deleted the optimization branch June 20, 2023 15:21
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant