Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace mixed line ending commit hook with .gitattributes. #474

Open
wants to merge 1 commit into
base: publicapi
Choose a base branch
from

Conversation

HexDecimal
Copy link
Contributor

This commit hook was causing me some issues. Since I use autoclrf I don't upload mixed line endings on commits even without a hook preventing it, but that's a local setting.

A .gitattributes file enforces line endings regardless of local settings. This does what this commit hook was intending to do but works better across platforms.

This commit hook was preventing me from committing, but since I use
autoclrf I don't upload mixed line endings on commits even without a
hook preventing it.

A .gitattributes file enforces line endings regardless of local
settings.  This does what this commit hook was intending to do but works
better across platforms.
@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Base: 68.76% // Head: 68.76% // No change to project coverage 👍

Coverage data is based on head (c69200e) compared to base (c85a333).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           publicapi     #474   +/-   ##
==========================================
  Coverage      68.76%   68.76%           
==========================================
  Files             11       11           
  Lines            986      986           
==========================================
  Hits             678      678           
  Misses           308      308           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant