-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix failing CI #943
Fix failing CI #943
Conversation
Looks like
|
Yeah, I started looking into this in #936, but haven't had the time to dig into it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We still care about coverage and there are ways to display it in CI. But we can add it back eventually I guess
The results are still displayed in CI: https://github.com/pypa/twine/actions/runs/3577925730/jobs/6017490264#step:6:110 Do you mean adding comments on PRs like CodeCov did? |
As noted in #658 (comment) (and subsequent comments), I think it'd be nice to make the HTML report available. |
I think once nedbat/coveragepy#1418 is released, this would be as simple as: - python -m coverage report -m --fail-under 97
+ python -m coverage report -m --fail-under 97 --format=markdown >> $GITHUB_STEP_SUMMARY
https://github.blog/2022-05-09-supercharging-github-actions-with-job-summaries/ |
FWIW the workflow used a long-deprecated version of the action (v1). The current v3 is usually working well. |
@di FYI, it is possible to implement this right now with |
CodeCov's services seem to be getting more and more unavailable, and are causing our tests to fail (e.g., https://github.com/pypa/twine/actions/runs/3577489389/jobs/6016720780).
This PR removes CodeCov entirely in favor of running
coverage
in CI and asserting on some coverage percentage, currently 97%.Fixes #658. This includes #942 to get CI to pass, closes #942. Closes #936.