Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using vendored distutils._modified directly in build_clib #4233

Closed
wants to merge 2 commits into from
Closed

Using vendored distutils._modified directly in build_clib #4233

wants to merge 2 commits into from

Conversation

Avasam
Copy link
Contributor

@Avasam Avasam commented Feb 23, 2024 •
edited
Loading

Summary of changes

Noticed here #3979 (comment)

_modified doesn't exist in stdlib (it was added in the vendored distutils). And distutils.dep_util.newer_pairwise_group doesn't exist either. So I don't see why setuptools.modified or .._distutils._modified couldn't always be used directly.

Work towards #2345 by having 1 less untyped import

Pull Request Checklist

  • Changes have tests (existing SETUPTOOLS_USE_DISTUTILS tests should pass)
  • News fragment added in newsfragments/.
    (See documentation for details)

@Avasam
Copy link
Contributor Author

Avasam commented Feb 25, 2024

Well this didn't work the way I thought it would.

@Avasam Avasam closed this Feb 25, 2024
@Avasam Avasam deleted the distutils._modified branch May 9, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Avasam