Fail fast when use_2to3 is supplied. #2770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
1 task
webknjaz
reviewed
Sep 7, 2021
| @@ -289,6 +289,10 @@ def assert_bool(dist, attr, value): | |||
| raise DistutilsSetupError(tmpl.format(attr=attr, value=value)) | |||
|
|
|||
|
|
|||
| def invalid(dist, attr, value): | |||
| raise DistutilsSetupError(f"{attr} is invalid.") | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
I originally was writing the function with this check, but then I wanted to make the "check" function suitable for any invalid value. I'll review the referenced bug and consider this proposal.
There was a problem hiding this comment.
Yeah, it turned out more impactful on the scale than you've probably expected. Seems rather urgent.
1 task
|
@jaraco Thank you for the fast and excellent fix. Much appreciated. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2769.