Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ssl_support. #2716

Merged
merged 2 commits into from
Jul 4, 2021
Merged

Remove ssl_support. #2716

merged 2 commits into from
Jul 4, 2021

Conversation

jaraco
Copy link
Member

@jaraco jaraco commented Jul 4, 2021

Fixes #2715.

It appears that ssl.match_hostname has been deprecated since Python 3.7 and without any replacement. Perhaps that means that hostname verification is built into the default URL openers, or maybe it means the functionality isn't supported any longer. In either case, since the Setuptools package index code is deprecated, there's no point in trying to drag this functionality into the future, so just rely on what on the default implementation for HTTPS connections.

@amotl
Copy link

amotl commented Sep 5, 2023

Thoughts about replacement for find_ca_bundle

Dear Jason,

at crate/crate-python#523 (comment), we discovered setuptools dropped the setuptools.ssl_support module.

We have been using setuptools.ssl_support.find_ca_bundle within our test suite, which croaks like 1 when using a more recent version of setuptools.

Maybe you have any sort of suggestion how to resolve that, other than vendoring the previous version of the setuptools.ssl_support module into the failing testsuite?

With kind regards,
Andreas.

Footnotes

  1. https://github.com/crate/crate-python/actions/runs/5480142715/job/14840796866?pr=558#step:4:226

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] ssl.match_hostname is deprecated
2 participants