Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Specify version for test PEP621 metadata #867

Merged
merged 1 commit into from
Jun 22, 2023

Conversation

stanislavlevin
Copy link
Contributor

According to today's specification
https://packaging.python.org/en/latest/specifications/declaring-project-metadata/#specification

The only keys required to be statically defined are:

  • name

The keys which are required but may be specified either statically or listed as dynamic are:

  • version

Fixes: #866

According to today's specification
https://packaging.python.org/en/latest/specifications/declaring-project-metadata/#specification

> The only keys required to be statically defined are:
  -  name
  The keys which are required but may be specified either
  statically or listed as dynamic are:
  - version

Fixes: pypa#866
Signed-off-by: Stanislav Levin <slev@altlinux.org>
Copy link
Contributor

@RonnyPfannschmidt RonnyPfannschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, please ensure pre commit is happy as well

@stanislavlevin
Copy link
Contributor Author

pre-commit failure is not related to this PR:

/pc/clone/mfyWJyPlQme6uKopNAOPKw/py_env-3.10/lib/python3.10/site-packages/markdown_it/common/utils.py:106: error: Assignment expressions are only supported in Python 3.8 and greater  [syntax]
Found 1 error in 1 file (errors prevented further checking)

Should it be fixed separately?

@RonnyPfannschmidt
Copy link
Contributor

RonnyPfannschmidt commented Jun 22, 2023

Oouch, Yeah that needs separate

@RonnyPfannschmidt
Copy link
Contributor

RonnyPfannschmidt commented Jun 22, 2023

Are you okay with squash merge?

@stanislavlevin
Copy link
Contributor Author

Yeah, no problem.

@RonnyPfannschmidt RonnyPfannschmidt merged commit 87c4e78 into pypa:main Jun 22, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[self-tests] few tests fail against setuptools 68.0.0
2 participants