Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add test for building with unicode filenames #355

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

bpabel
Copy link
Contributor

@bpabel bpabel commented Jun 14, 2020

Added an explicit test for building against unicode filenames that I neglected to add with the last PR.

files = [
'pyproject.toml',
'packageunicode/__init__.py',
u'packageunicode/No\\u00ebl.jpg',
Copy link
Member

@takluyver takluyver Jun 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
u'packageunicode/No\\u00ebl.jpg',
'packageunicode/No\\u00ebl.jpg',

We don't need to worry about Python 2 here. :-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m trying to figure out why the appveyor ci is failing. The tests all run successfully locally with tox.

@mohdzahidabdullah

This comment was marked as spam.

@takluyver
Copy link
Member

Let's see how this goes with the current test pipeline.

@takluyver takluyver closed this Feb 6, 2023
@takluyver takluyver reopened this Feb 6, 2023
@takluyver
Copy link
Member

Still no dice:

   E               FileNotFoundError: [WinError 2] The system cannot find the file specified: 'C:\\Users\\runneradmin\\AppData\\Local\\Temp\\pytest-of-unknown\\pytest-0\\test_build_package_with_unicod0\\packageunicode\\packageunicode\\Noël.jpg'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants